core(csp-xss): csp evaluator npm module #12221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
changed the title
adamraine
commented
Mar 8, 2021
|
|
||
| /* eslint-env jest */ | ||
|
|
||
| describe('Evaluator compatibility', () => { |
Contributor
Author
There was a problem hiding this comment.
This was just a sanity check since the previous method of importing CSP evaluator was irregular. We shouldn't need it now.
adamraine
commented
Mar 10, 2021
Comment on lines
-135
to
-137
| const results = [ | ||
| ...findings.map(this.findingToTableItem), | ||
| ]; |
adamraine
commented
Mar 10, 2021
| /** | ||
| * @param {string[]} rawCsps | ||
| */ | ||
| function evaluateRawCspForFailures(rawCsps) { |
Contributor
Author
There was a problem hiding this comment.
Helper functions added so i didn't need to change every single test case.
paulirish
approved these changes
Mar 15, 2021
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
two minor things but otherwise lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm module is published #12044 (comment)
We can get rid of the google3 binary and the irregular method of importing.
Reduces devtools bundle size by ~45KB.