core(errors-in-console): properly define default options #12200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
Mar 4, 2021
brendankenny
force-pushed
the
errorsdefaultoptions
branch
from
66f9e7b to
b674aab
Compare
paulirish
pushed a commit
that referenced
this pull request
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10198
#11901 did the real fix, but didn't notice that #9480 had defined the previously empty
defaultOptionsas a static method and not a getter.Classic case of unit vs integration tests:
audit-runnerdoes and using that for all unit tests instead of calling.audit()directly. That would take care of context being initialized correctly and it would do theAuditProduct->AuditResulttransformation so tests could run on the real audit output expected in the LHR.