Skip to content

tests(devtools): update chromium dependencies #12130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
connorjclark merged 7 commits into from
Mar 11, 2021
Merged

tests(devtools): update chromium dependencies #12130

connorjclark merged 7 commits into from
Mar 11, 2021

Conversation

@paulirish
Copy link
Member

@paulirish paulirish commented Feb 24, 2021

They're currently 8mo old.

These new hashes are from today/now.

Everything looks good locally. Hoping it's also fine on gha CI.

@paulirish paulirish requested a review from a team as a code owner February 24, 2021 01:49
@google-cla google-cla bot added the cla: yes label Feb 24, 2021
@connorjclark
Copy link
Collaborator

connorjclark commented Feb 24, 2021 •
edited
Loading 

+ python /Users/runner/work/lighthouse/lighthouse/blink_tools/latest/third_party/blink/tools/run_web_tests.py --layout-tests-directory=/Users/runner/work/lighthouse/lighthouse/devtools-frontend/test/webtests --build-directory=/Users/runner/work/lighthouse/lighthouse/lighthouse/lighthouse-core/test/chromium-web-tests/../../../.tmp/chromium-web-tests/content-shells/856945/out http/tests/devtools/lighthouse
Traceback (most recent call last):
  File "/Users/runner/work/lighthouse/lighthouse/blink_tools/4ffbceb9e46813c0041c27d52fbcd180348ae073370c3d98a6db53222e9f36a4491a3757bb93e61a/third_party/blink/tools/blinkpy/web_tests/run_web_tests.py", line 37, in <module>
    from blinkpy.common.host import Host
  File "/Users/runner/work/lighthouse/lighthouse/blink_tools/4ffbceb9e46813c0041c27d52fbcd180348ae073370c3d98a6db53222e9f36a4491a3757bb93e61a/third_party/blink/tools/blinkpy/common/host.py", line 32, in <module>
    from blinkpy.common.checkout.git import Git
  File "/Users/runner/work/lighthouse/lighthouse/blink_tools/4ffbceb9e46813c0041c27d52fbcd180348ae073370c3d98a6db53222e9f36a4491a3757bb93e61a/third_party/blink/tools/blinkpy/common/checkout/git.py", line 34, in <module>
    from blinkpy.common.system.executive import Executive, ScriptError
  File "/Users/runner/work/lighthouse/lighthouse/blink_tools/4ffbceb9e46813c0041c27d52fbcd180348ae073370c3d98a6db53222e9f36a4491a3757bb93e61a/third_party/blink/tools/blinkpy/common/system/executive.py", line 42, in <module>
    import six
ImportError: No module named six

guess they are transitioning to py3. try adding pip install six in action yml?

@connorjclark connorjclark changed the title tests(devtools): update commit markers tests(devtools): update chromium dependencies Feb 24, 2021
@connorjclark connorjclark merged commit e59b912 into master Mar 11, 2021
@connorjclark connorjclark deleted the webtestupdates branch March 11, 2021 21:36
paulirish added a commit that referenced this pull request Mar 23, 2021
@paulirish
tests(devtools): update chromium dependencies (#12130)
4fa8106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connorjclark connorjclark connorjclark approved these changes

Assignees

@connorjclark connorjclark

Labels

cla: yes waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulirish @connorjclark @devtools-bot