Skip to content

tests(smoke): restore dbw_tester exception assertions #11836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devtools-bot merged 2 commits into from
Dec 16, 2020
Merged

tests(smoke): restore dbw_tester exception assertions #11836

devtools-bot merged 2 commits into from
Dec 16, 2020

Conversation

@paulirish
Copy link
Member

@paulirish paulirish commented Dec 16, 2020 •
edited
Loading

closes #11803 now that the top-level-await chromium bug is fixed.

reverts much of #11799 but also takes into account the consoleMessages changes in #11663

also reverts #11813

@paulirish paulirish requested a review from a team as a code owner December 16, 2020 01:58
@paulirish paulirish requested review from Beytoven and removed request for a team December 16, 2020 01:58
@google-cla google-cla bot added the cla: yes label Dec 16, 2020
@brendankenny
Copy link
Contributor

brendankenny commented Dec 16, 2020

can we revert #11813 too?

@paulirish
Copy link
Member Author

paulirish commented Dec 16, 2020

can we revert #11813 too?

yes

brendankenny
brendankenny approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devtools-bot devtools-bot merged commit 9dbb0a5 into master Dec 16, 2020
@devtools-bot devtools-bot deleted the tla-regression branch December 16, 2020 17:30
@paulirish paulirish mentioned this pull request Dec 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Beytoven Beytoven Awaiting requested review from Beytoven

1 more reviewer

@brendankenny brendankenny brendankenny approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Beytoven Beytoven

Labels

cla: yes waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unexpected aggressive-promise-polyfill error on dbwtester

4 participants

@paulirish @brendankenny @devtools-bot @Beytoven