core(config): only allow lighthouse:default extension #11835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oh good call on getting this in before 7. Drop the Line 20 in ced75b5 |
Contributor
|
Can you also update: lighthouse/docs/configuration.md Lines 49 to 53 in 6e0158d |
Collaborator
Author
|
Done and done, thanks @brendankenny @adamraine ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes the loop on a few consequences @paulirish and I discussed of #11779. Breaking change to eventually allow extension of
lighthouse:mobileandlighthouse:desktopbut make it clearer when yourextendsproperty is valid.Before
Any truthy value for a config's
extendsproperty would trigger extension of the default config.After
Any value other than
lighthouse:defaultfor a config'sextendsproperty throws a fatal error.Related Issues/PRs
ref #11779
#10910 (comment)