misc: temporarily allow css in redirectPass #11813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
smoke_2_ToT did pass... |
Member
makes no sense to me. but... top level await's impl is complicated. apparently. landing this wfm as i really dont wanna do the revert/reland dance :) |
paulirish
approved these changes
Dec 11, 2020
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
and also, blocking one less optional thing aint a huge deal.
paulirish
added a commit
that referenced
this pull request
Dec 16, 2020
This reverts commit 5b4b47c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #11812.
The theory is that the combo of some js and link preloading a css file is causing this load failure (see #11803 (comment)). Previous to #11711 JS was blocked from running in the
redirectPass.Now JS is allowed, but css is still blocked from loading via
default-config'sblockedUrlPatterns. Removing that one css load reliably caused ToT to "Aw, Snap!" for me locally, so we've essentially recreated that situation in redirectPass.We can see if allowing CSS to load will go back to a bad Promise error but no Aw, Snap.