tests: reenable change-related tests in github actions #11801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
commented
Dec 9, 2020
| @@ -0,0 +1,25 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -euo pipefail | |||
Collaborator
Author
There was a problem hiding this comment.
seems like we've started putting some scripts in .github, preference for moving this there?
connorjclark
reviewed
Dec 9, 2020
| @@ -0,0 +1,25 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -euo pipefail | |||
| exit 1 | ||
| fi | ||
|
|
||
| GITHUB_ACTIONS_COMMIT_RANGE="${BASE_SHA}..${GITHUB_SHA}" |
Collaborator
There was a problem hiding this comment.
don't you need to export?
Collaborator
Author
There was a problem hiding this comment.
nope, that wouldn't pierce between github steps and what echo >> $GITHUB_ENV is doing, added a comment
Collaborator
|
|
patrickhulce
changed the title
connorjclark
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None of our longer change-gated test suites have been running in GitHub Actions because we relied on
$TRAVIS_COMMIT_RANGE. This is actually sort of a PITA to get from GitHub Actions so created a script that exports it to an env variable.Aside: seems like there might be some overlap here with what the buildtracker git deepening script is doing?
Related Issues/PRs
ref #11767 (comment)