misc: update run-devtools script to use a list of urls #11751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested changes
Dec 2, 2020
Collaborator
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
Is it possible to have just one script for n=1 and n=many? As I understand, the only difference would be that for the n=1 case the file would be named devtools-lhr-0.json instead of devtools-lhr.json, which is fine.
lighthouse-core/test/chromium-web-tests/batch-test-pages-devtools.sh
Outdated
Show resolved
Hide resolved
lighthouse-core/test/chromium-web-tests/batch-test-pages-devtools.sh
Outdated
Show resolved
Hide resolved
| http/tests/devtools/lighthouse-run | ||
| set -e | ||
|
|
||
| OUTPUT_DIR="$LH_ROOT/latest-run/devtools-lhrs" |
Collaborator
There was a problem hiding this comment.
@patrickhulce how do you feel about using this folder for this? Or should we stuff it in .tmp/devtools-lhrs?
lighthouse-core/test/chromium-web-tests/batch-test-pages-devtools.sh
Outdated
Show resolved
Hide resolved
lighthouse-core/test/chromium-web-tests/batch-test-pages-devtools.sh
Outdated
Show resolved
Hide resolved
connorjclark
reviewed
Dec 7, 2020
Collaborator
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
awesome, thanks for reworking it so much!
| echo "Creating test files for URLs" | ||
| COUNTER=0 | ||
| while read url; do | ||
| [[ -z $url || ${url:0:1} == "#" ]] && continue |
Collaborator
There was a problem hiding this comment.
nice idea with the comment
Contributor
Author
There was a problem hiding this comment.
It was necessary for our example urls.txt
Beytoven
approved these changes
Dec 8, 2020
connorjclark
approved these changes
Dec 9, 2020
adamraine
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #11539
This script significantly reduces the overhead for running Lighthouse on each URL. The input to this script is a path to a txt file rather than a single URL.
This PR also fixes an error where the content shell would crash on some pages.