tests: update failing trace webtest to use Tooltip module #11731
Conversation
|
The reason the test wasn't failing is that the getter was previously implicitly calling |
connorjclark
changed the title
|
@connorjclark FYI this is failing the devtools check with |
|
weird, it works for me locally even after I clear |
| ${{ env.BLINK_TOOLS_PATH }} | ||
| ${{ github.workspace }}/lighthouse/.tmp/chromium-web-tests/content-shells | ||
| key: ${{ runner.os }}-${{ hashFiles('lighthouse/.github/workflows/devtools.yml', 'lighthouse/lighthouse-core/test/chromium-web-tests/*', 'lighthouse/clients/devtools-entry.js', 'lighthouse/clients/devtools-report-assets.js', 'lighthouse/build/build-bundle.js', 'lighthouse/build/build-dt-report-resources.js') }} | ||
| key: ${{ runner.os }}-${{ hashFiles('third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/*.js', 'lighthouse/.github/workflows/devtools.yml', 'lighthouse/lighthouse-core/test/chromium-web-tests/*', 'lighthouse/clients/devtools-entry.js', 'lighthouse/clients/devtools-report-assets.js', 'lighthouse/build/build-bundle.js', 'lighthouse/build/build-dt-report-resources.js') }} |
There was a problem hiding this comment.
I assumed the test files were already apart of this hash. This should fix CI.
5 participants
Changed here: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2555060
I'd expect that change to fail this test https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/test/webtests/http/tests/devtools/lighthouse/lighthouse-view-trace-run.js;l=36;drc=b736005f57eccddf8dd024872552f1bfb0264682 but it didn't. @TimvdLippe I assumed
test/webtestsrun in CQ, is that true?