core(image-elements): surface css properties in artifact #11707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itydescriptor prop, not needed.
adrianaixba
requested review from
patrickhulce
and removed request for
a team
patrickhulce
suggested changes
Nov 30, 2020
types/artifacts.d.ts
Outdated
| */ | ||
| usesSrcSetDensityDescriptor: boolean; | ||
| /** `object-fit` CSS property. */ | ||
| ObjectFit: string; |
Collaborator
There was a problem hiding this comment.
Suggested change
| ObjectFit: string; | |
| cssComputedObjectFit: string; |
WDYT to match the other cssComputed* property convention?
Collaborator
Author
There was a problem hiding this comment.
I like this! Makes a lot more sense and matches other properties 👍
patrickhulce
suggested changes
Dec 7, 2020
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
change itself looks good! 🎉
just a few leftover minor comments
patrickhulce
approved these changes
Dec 8, 2020
Collaborator
|
sorry @adrianaixba you'll have some conflicts with #11695 landing now, looks great though! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surface css properties in ImageElements artifact. Move property validation logic to audits.
First item of #11642