Skip to content

Commit 2aa9845

Browse files
BeytovenBeytoven
authored
core(without-javascript): remove audit (#11711)
1 parent 6ad47fa commit 2aa9845

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+8
-944
lines changed

‎lighthouse-cli/test/cli/__snapshots__/index-test.js.snap‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ Object {
1818
Object {
1919
"path": "viewport",
2020
},
21-
Object {
22-
"path": "without-javascript",
23-
},
2421
Object {
2522
"path": "metrics/first-contentful-paint",
2623
},
@@ -1144,11 +1141,6 @@ Object {
11441141
"id": "viewport",
11451142
"weight": 2,
11461143
},
1147-
Object {
1148-
"group": "pwa-optimized",
1149-
"id": "without-javascript",
1150-
"weight": 1,
1151-
},
11521144
Object {
11531145
"group": "pwa-optimized",
11541146
"id": "apple-touch-icon",
@@ -1486,9 +1478,6 @@ Object {
14861478
Object {
14871479
"path": "http-redirect",
14881480
},
1489-
Object {
1490-
"path": "html-without-javascript",
1491-
},
14921481
],
14931482
"loadFailureMode": "warn",
14941483
"networkQuietThresholdMs": 0,

‎lighthouse-cli/test/smokehouse/test-definitions/offline-local/offline-config.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ module.exports = {
2020
'service-worker',
2121
'works-offline',
2222
'viewport',
23-
'without-javascript',
2423
'user-timings',
2524
'critical-request-chains',
2625
'render-blocking-resources',

‎lighthouse-cli/test/smokehouse/test-definitions/offline-local/offline-expectations.js‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,6 @@ module.exports = [
4747
'viewport': {
4848
score: 1,
4949
},
50-
'without-javascript': {
51-
score: 1,
52-
},
5350
'user-timings': {
5451
scoreDisplayMode: 'notApplicable',
5552
},
@@ -142,9 +139,6 @@ module.exports = [
142139
'viewport': {
143140
score: 1,
144141
},
145-
'without-javascript': {
146-
score: 1,
147-
},
148142
'user-timings': {
149143
scoreDisplayMode: 'notApplicable',
150144
},

‎lighthouse-cli/test/smokehouse/test-definitions/pwa/pwa-expectations.js‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@ const expectations = [
3636
'viewport': {
3737
score: 1,
3838
},
39-
'without-javascript': {
40-
score: 1,
41-
},
4239
'installable-manifest': {
4340
score: 1,
4441
details: {items: [pwaDetailsExpectations]},
@@ -98,9 +95,6 @@ const expectations = [
9895
'viewport': {
9996
score: 1,
10097
},
101-
'without-javascript': {
102-
score: 1,
103-
},
10498
'installable-manifest': {
10599
score: 0,
106100
},

‎lighthouse-cli/test/smokehouse/test-definitions/pwa/pwa2-expectations.js‎

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@ module.exports = [
2323
score: 1,
2424
},
2525
'redirects-http': {
26-
// Note: relies on JS redirect.
27-
// see https://github.com/GoogleChrome/lighthouse/issues/2383
28-
score: 0,
26+
score: 1,
2927
},
3028
'service-worker': {
3129
score: 1,
@@ -39,9 +37,6 @@ module.exports = [
3937
'viewport': {
4038
score: 1,
4139
},
42-
'without-javascript': {
43-
score: 1,
44-
},
4540
'installable-manifest': {
4641
score: 0,
4742
details: {items: [jakeExpectations]},
@@ -105,9 +100,6 @@ module.exports = [
105100
'viewport': {
106101
score: 1,
107102
},
108-
'without-javascript': {
109-
score: 1,
110-
},
111103
'installable-manifest': {
112104
score: 1,
113105
details: {items: [{...pwaDetailsExpectations, manifestUrl: 'https://caltrainschedule.io/manifest.json'}]},

‎lighthouse-cli/test/smokehouse/test-definitions/pwa/pwa3-expectations.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,6 @@ module.exports = [
3939
'viewport': {
4040
score: 1,
4141
},
42-
'without-javascript': {
43-
score: 1,
44-
},
4542
'installable-manifest': {
4643
score: 1,
4744
details: {items: [pwaRocksExpectations]},

‎lighthouse-core/audits/without-javascript.js‎

Lines changed: 0 additions & 62 deletions
This file was deleted.

‎lighthouse-core/config/default-config.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,6 @@ const defaultConfig = {
183183
blockedUrlPatterns: ['*.css', '*.jpg', '*.jpeg', '*.png', '*.gif', '*.svg', '*.ttf', '*.woff', '*.woff2'],
184184
gatherers: [
185185
'http-redirect',
186-
'html-without-javascript',
187186
],
188187
}],
189188
audits: [
@@ -192,7 +191,6 @@ const defaultConfig = {
192191
'service-worker',
193192
'works-offline',
194193
'viewport',
195-
'without-javascript',
196194
'metrics/first-contentful-paint',
197195
'metrics/largest-contentful-paint',
198196
'metrics/first-meaningful-paint',
@@ -622,7 +620,6 @@ const defaultConfig = {
622620
{id: 'themed-omnibox', weight: 1, group: 'pwa-optimized'},
623621
{id: 'content-width', weight: 1, group: 'pwa-optimized'},
624622
{id: 'viewport', weight: 2, group: 'pwa-optimized'},
625-
{id: 'without-javascript', weight: 1, group: 'pwa-optimized'},
626623
{id: 'apple-touch-icon', weight: 1, group: 'pwa-optimized'},
627624
{id: 'maskable-icon', weight: 1, group: 'pwa-optimized'},
628625
// Manual audits

‎lighthouse-core/gather/driver.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,7 +682,6 @@ class Driver {
682682
const waitForLoad = options.waitForLoad || false;
683683
/** @type {Partial<LH.Gatherer.PassContext>} */
684684
const passContext = options.passContext || {};
685-
const disableJS = passContext.disableJavaScript || false;
686685

687686
if (waitForNavigated && (waitForFcp || waitForLoad)) {
688687
throw new Error('Cannot use both waitForNavigated and another event, pick just one');
@@ -701,7 +700,6 @@ class Driver {
701700

702701
await this.sendCommand('Page.enable');
703702
await this.sendCommand('Page.setLifecycleEventsEnabled', {enabled: true});
704-
await this.sendCommand('Emulation.setScriptExecutionDisabled', {value: disableJS});
705703
// No timeout needed for Page.navigate. See https://github.com/GoogleChrome/lighthouse/pull/6413.
706704
const waitforPageNavigateCmd = this._innerSendCommand('Page.navigate', undefined, {url});
707705

‎lighthouse-core/gather/gatherers/html-without-javascript.js‎

Lines changed: 0 additions & 56 deletions
This file was deleted.

0 commit comments

Comments
 (0)