This repository was archived by the owner on Mar 14, 2024. It is now read-only.
Update Lighthouse is-crawlable audit doc
#5111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for developer-chrome-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
13 tasks
connorjclark
reviewed
Feb 1, 2023
|
|
||
| Lighthouse doesn't check for crawler-specific directives like this, but they can | ||
| still make your page harder to discover, so use them with caution. | ||
| Lighthouse doesn't fail the audit for crawler-specific directives like this, but they can |
Contributor
There was a problem hiding this comment.
Shoudl we qualify this as "as of 10.0"? Must account for chrome stable running older LH longer than other channels; and to a lesser extent, historical LH versions.
Contributor
Author
There was a problem hiding this comment.
I don't think we need a 10.0 disclaimer for something as minor as this
connorjclark
approved these changes
Feb 1, 2023
Contributor
connorjclark
left a comment
connorjclark
left a comment
There was a problem hiding this comment.
+1, but merging should hold for our release.
brendankenny
approved these changes
Feb 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GoogleChrome/lighthouse#5329
Lighthouse will now look for crawler-specific directives and emit a warning if they are found: GoogleChrome/lighthouse#14550
cc @connorjclark