Add a new status: changes requested #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en a validator adds a comment in the feedback
…when a validator adds a comment in the textarea
…ble_changes_requested_status
akirk
approved these changes
Sep 15, 2022
Member
akirk
left a comment
akirk
left a comment
There was a problem hiding this comment.
I've tested it and I couldn't find problems, let's go with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR, with another one in the GlotPress plugin, adds a new status: changes requested.
Solution
This plugin only send the information with a new status (changes_requested) when:
Testing instructions
To test this PR, you have to use the related branch from GlotPress and you have to reject some strings as validator (simple or bulk rejection), adding some feedback.