Make the glossary regex more deterministic#1801
Merged
Merged
Conversation
amieiro
approved these changes
Feb 28, 2024
Member
|
It works here, thanks :) |
|
Currently this still does not work for locale nl_NL, as "select" is in our glossary, but "selection" is not. Still GlotPress indicates "selection" as glossary word, which is not true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@amieiro noticed that with the Spanish glossary, a term didn't match that existed in the Glossary. On the other hand, Portuguese, which had the same rivalling terms got it right:
The problem arises from the fact that we now group the regex by suffixes. For each English term the suffix is determined and the term sorted into that bin and the regex is built from those bins.
Add-on and Add fall in different bins (the first just with an "s" suffix, the second with possible suffixes "s", "ed", or "ing") but in Spanish the second bin is created first because in the sequence of glossary terms, the word "troubleshooting" that starts the bin is processed before "customization" which crates the "s" bin. In Portuguese its reversed, more or less by chance, because "customization" is processed before "downgrading":
Solution
The proposed solution of making the regex more deterministic so that there are not differences between languages. In this case it fixes the problem but there could be other occurrences where a
krsortwould make it work. We need toTesting Instructions
Create a language with a glossary that contains the words "troubleshooting", "customization", "add", and "add-on" and an original that contains the word "Add-on". Before this PR it will only match the "add".