Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the breadcrumbs for the "New project" actions #1800

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

amieiro
Copy link
Member

@amieiro amieiro commented Feb 26, 2024

Problem

In #1789 we improved the consistency across all content types of breadcrumbs, but we forgot one situation: the "New project" creation, both at the top level and as a subproject.

image

Solution

This PR adds the link to the current project in the breadcrumbs.

image

image

Fixes #1799.

Testing Instructions

Try to:

  • Create a new project in the GlotPress root path.
  • Create a new subproject in a GlotPress project.

In both situations, you should see the correct links to the current project.

Copy link
Member

@pedro-mendonca pedro-mendonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead of this, you could keep the existent logic, but only add the item to $links[] if the project->id isn't null.

Co-authored-by: Pedro Mendonça <[email protected]>
@amieiro
Copy link
Member Author

amieiro commented Feb 27, 2024

I think instead of this, you could keep the existent logic, but only add the item to $links[] if the project->id isn't null.

Thank you for this improvement.

Copy link
Member

@pedro-mendonca pedro-mendonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! :)

@amieiro amieiro merged commit 2723aa5 into GlotPress:develop Feb 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We do not have a link to the project in the breadcrumbs when we create a new project
2 participants