Add the breadcrumbs for the "New project" actions #1800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pedro-mendonca
left a comment
pedro-mendonca
left a comment
There was a problem hiding this comment.
I think instead of this, you could keep the existent logic, but only add the item to $links[] if the project->id isn't null.
Co-authored-by: Pedro Mendonça <[email protected]>
Member
Author
Thank you for this improvement. |
pedro-mendonca
approved these changes
Feb 27, 2024
Member
pedro-mendonca
left a comment
pedro-mendonca
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #1789 we improved the consistency across all content types of breadcrumbs, but we forgot one situation: the "New project" creation, both at the top level and as a subproject.
Solution
This PR adds the link to the current project in the breadcrumbs.
Fixes #1799.
Testing Instructions
Try to:
In both situations, you should see the correct links to the current project.