Breadcrumbs: Improve consistency across all content types #1789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amieiro
reviewed
Feb 23, 2024
amieiro
reviewed
Feb 23, 2024
amieiro
reviewed
Feb 23, 2024
Member
amieiro
left a comment
amieiro
left a comment
There was a problem hiding this comment.
I have just reviewed the code and the functionality, and it works nice. Good job!
I have suggested two small changes in the gp_breadcrumb_projectfunction. Please, take a look and then I will merge this PR. Thank you!
Co-authored-by: Jesús Amieiro Becerra <[email protected]>
Co-authored-by: Jesús Amieiro Becerra <[email protected]>
Member
Author
|
Thanks for the review @amieiro |
amieiro
approved these changes
Feb 23, 2024
This was referenced Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As described in #1788, there are several inconsistencies in the breadcrumbs:
Solution
gp_breadcrumb_project()with extra optional items, with backwards compatibility. If no extra items, the last item (project->name) is used without link. If not empty, all the links are outputed and the extra items are appended (Translation Set, Glossary, action, etc)Testing Instructions
Navigate through all the possible pages:
Etc.
Screenshots
Locales and Global glossaries
Projects
Translation Sets and Project glossaries
Fixes #1788