Fix fatal error in PHP8.x for invalid get data #1754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd32
previously approved these changes
Jan 5, 2024
Co-authored-by: Dion Hulse <[email protected]>
Co-authored-by: Dion Hulse <[email protected]>
trymebytes
reviewed
Jan 24, 2024
trymebytes
previously approved these changes
Jan 24, 2024
Contributor
trymebytes
left a comment
trymebytes
left a comment
There was a problem hiding this comment.
I left a tiny comment but looks good to me!
trymebytes
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A malformed sort array throws a fatal error in PHP 8.x (in PHP 7.4 throws a warning).
Before this fix, if you add
?sort[by][foobar]=1to a GlotPress URL, in a GET request, you will get anerror 500.Before
After
Fixes #1753.
Solution
The malformed URL throws an error at
wp-content/plugins/GlotPress/gp-includes/misc.php on line 66because the$keyparameter in thegp_array_get()function is an array. This PR checks if the$keyis a string or a number before using it as key in the array.After solving this first problem, it arises another warning:
This problem is solved removing the values from the filters that are not strings or numbers.