Skip to content

Glossary: Fix fatal array in PHP8 for invalid post data #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amieiro merged 4 commits into from
Dec 21, 2023
Merged

Glossary: Fix fatal array in PHP8 for invalid post data #1750

amieiro merged 4 commits into from
Dec 21, 2023

Conversation

@akirk
Copy link
Member

@akirk akirk commented Dec 21, 2023

Fixes #1749.

Before

$ curl https://php81.example.org/locale/en-au/default/glossary/ --data 'glossary_entry=foobar&bogus=data' -i
HTTP/1.1 500 Internal Server Error

$ curl https://php74.example.org/locale/en-au/default/glossary/ --data 'glossary_entry=foobar&bogus=data'
HTTP/1.1 200 OK
...
The glossary entry cannot be found

After

$ curl https://php81.example.org/locale/en-au/default/glossary/ --data 'glossary_entry=foobar&bogus=data' -i
HTTP/1.1 404 Not Found

$ curl https://php74.example.org/locale/en-au/default/glossary/ --data 'glossary_entry=foobar&bogus=data'
HTTP/1.1 404 Not Found
...
The glossary entry cannot be found

@akirk akirk requested review from amieiro, dd32 and trymebytes December 21, 2023 07:57
trymebytes
trymebytes previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@trymebytes trymebytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

amieiro
amieiro requested changes Dec 21, 2023
View reviewed changes
@amieiro
Copy link
Member

amieiro commented Dec 21, 2023

Now, it works fine for me.

@amieiro amieiro merged commit 8619715 into develop Dec 21, 2023
@amieiro amieiro deleted the fix-glossary-fatal branch December 21, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amieiro amieiro amieiro approved these changes

@trymebytes trymebytes trymebytes left review comments

@dd32 dd32 Awaiting requested review from dd32

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Warning/Fatal due to pentesting payloads

4 participants

@akirk @amieiro @trymebytes