[1732] Fix glossary matching left bounded by placeholder. #1733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
pedro-mendonca
force-pushed
the
glossary-placeholders-fix
branch
from
8415c1a to
667f8a5
Compare
amieiro
approved these changes
Jan 11, 2024
Member
amieiro
left a comment
amieiro
left a comment
There was a problem hiding this comment.
I have reviewed it, and it fixes the bug as it is expected.
It adds some good refactoring in the tests. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the string
%sshow, the wordshowisn't matched by the glossary because isn't left bounded by \b.Solution
Add the current placeholder matching pattern also as a possible left boundarie, as
\b.This PR also adds some methods to simplify writing testing code of glossary matches and to improve the readability of the tests.
Fixes #1732