Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused files #1723

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Remove unused files #1723

merged 3 commits into from
Jan 17, 2024

Conversation

amieiro
Copy link
Member

@amieiro amieiro commented Oct 16, 2023

Problem

In #1714, we change the tour library to driver.js. There are 2 previous assets not needed with driver.js.

Solution

This PR removes the unused assets:

  • assets/css/jquery.webui-popover.css
  • assets/css/jquery.webui-popover.min.css

@amieiro amieiro requested review from akirk and trymebytes October 16, 2023 17:41
@trymebytes
Copy link
Contributor

We made use of the popover in this PR - #1715 and there are still more usecases in the near time. I'll recommend that we keep the files.

@trymebytes
Copy link
Contributor

@amieiro since #1715 has been closed, we can move forward with this PR

@amieiro amieiro merged commit 385a662 into GlotPress:develop Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants