Deprecation. Check if the ctype_digit parameter is null #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Using PHP8.2, with a non logged user, when I access to a list of projects, I get a deprecation notice:
PHP Deprecated: ctype_digit(): Argument of type null will be interpreted as string in the future in /wordpress/glotpress/wp-content/plugins/GlotPress/gp-includes/thing.php on line 644Solution
Since PHP 8.1.0, passing a non-string argument to the
ctype_digitfunction is deprecated. More info here.This PR checks if the argument passed to
ctype_digitis not null, avoiding its execution in this situation.