Add a slash at the end of a requested URI #1701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trymebytes
previously approved these changes
Sep 25, 2023
Contributor
|
Tested and works for me. |
akirk
requested changes
Sep 25, 2023
Member
akirk
left a comment
akirk
left a comment
There was a problem hiding this comment.
I am skeptic of this approach. For routing there is a function request_uri(). I think we should be working with that instead of modifying a PHP superglobal.
akirk
reviewed
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When you access the https://glotpress.test/glotpress URI (without a slash at the end of the URI), you get a 404. Instead, if you add the slash at the end of the URI https://glotpress.test/glotpress/, you are redirected to https://glotpress.test/glotpress/projects/
Keep in mind, I am using https://glotpress.test/ as my main WordPress address. Please, change all the URI used in this description to the main URI used in your local installation.
Fixes #896.
Solution
This PR adds a slash at the end of the requested URI if it doesn't have it.
Testing Instructions
Test both URI in your local installation (with and without the final slash) before and after applying this PR:
Before applying the PR, you will get a 404 with the first URI. After applying the PR, you will be redirected to the GlotPress main page.