Dependencies for site tour #1684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add GP_SCRIPT_DEBUG to load the unminified CSS and JS * Update the default value for GP_SCRIPT_DEBUG to true * Update the Grunt action to minify a JS file and add a Grunt action to copy a JS and a CSS file * Add 3 files to the conditional loading: 2 CSS and 1 JS * Add the browserify action to the Grunt workflow * Add a concat action in the Grunt file to concat the CSS from inline-translation * Watch inline translation files * Use concat in favor of copy * Not part of the inline translation css * typo * typo * remove grunt-contrib-copy * remove unnecessary line * unification * whitespace * Update browserify destination * Update the location to load the inline-translation JS file * Remove the Makefile file, because all its work is now in the Grunt file --------- Co-authored-by: Alex Kirk <[email protected]>
* Move the jQuery popover file to the assets directory * Ignore the new location of the jquery.webui-popover
trymebytes
force-pushed
the
tour-prep
branch
from
8a4c42e to
0680dc9
Compare
amieiro
requested changes
Sep 6, 2023
Member
amieiro
left a comment
amieiro
left a comment
There was a problem hiding this comment.
You have added 2 dependencies in the package.json file:
"grunt-browserify": "^6.0.0",
"grunt-contrib-concat": "^2.1.0",
but you don't have the updates in the Gruntfile.js to use them. I think you need to get this update from this commit.
trymebytes
force-pushed
the
tour-prep
branch
from
4145ca0 to
60b651d
Compare
trymebytes
force-pushed
the
tour-prep
branch
from
60b651d to
e4a5c8f
Compare
amieiro
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the dependencies (from local branch) needed for the site tour to work to this PR.
The site-tour feature needs the jquery-popover to work, and the jquery-popover plugin has been added in this PR.