-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the highlight label from the active projects to the inactive #1680
Move the highlight label from the active projects to the inactive #1680
Conversation
@amieiro Lovely |
Talking about style, those Edit/Delete buttons look too much like tags. Should be made at least like the other buttons on the translation editor template. |
@pedro-mendonca are you talking about making them similar to the "Add translation" button, with small size? |
The editor has two types, primary (Add translation) and the secondary type for the above buttons. |
@pedro-mendonca Yes, it makes sense, of course. I will do this improvement. We have then in:
|
Maybe is better do open another issue/PR for that :) |
It's looking good. |
@amieiro I suggest using the class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some suggestions to the PR in amieiro#3
@pedro-mendonca I am trying to apply this patch to my PR to review it. Thank you! |
@pedro-mendonca I have applied your PR to my PR, but I can't see anything in the bubble, because it has the background and the text color set to white. |
That doesn't seem like the CSS of my PR. |
@amieiro I've consolidated the CSS for the inactive bubbles in amieiro@7583d11 |
Use GP buttons (small) for action links in projects, glossary and tra…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my perspective this is good to go! Tested it and the Inactive bubbles appear in the right places, and the Active markers are gone.
Problem
As is explained in #1335, GlotPress shows a small label:
GlotPress doesn't show this label when the user access to the translation set, selecting a translation language.
Fixes #1335.
Solution
This PR inverts the bubble appareance, showing them only:
The active projects don't have the bubble in the breadcrumb.
I have decided to use the "Inactive" word instead of "Archived", because the project status is active or inactive, not archived.
Testing Instructions
To test this change, you only need to navigate between a project with active and inactive subprojects, to see the new approach for the bubbles.