Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid adding the invisible classes in the glossary #1664

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

amieiro
Copy link
Member

@amieiro amieiro commented Jul 26, 2023

Problem

If the comment in an element of the glossary has two spaces, the prepare_original function breaks the originals in the translation table.

image

image

Solution

This PR avoids adding the invisible classes in the glossary, applying the glossary as the last element in the prepare_original function.

image

Testing Instructions

To test this PR:

  1. Add an element in the glossary with two spaces in the comment.
  2. Test that this breaks the original string in the translation table.
  3. Test that this PR doesn't break the original string in the translation table.

@amieiro amieiro self-assigned this Jul 26, 2023
@amieiro amieiro requested review from akirk and trymebytes July 26, 2023 22:54
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that this fixes the issue!

@amieiro amieiro merged commit cc09bd2 into GlotPress:develop Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants