Skip to content

Conversation

@akirk akirk requested a review from amieiro July 21, 2023 08:49
@akirk
Copy link
Member Author

akirk commented Jul 21, 2023

I have tested this on translate.wordpress.org

amieiro and others added 27 commits August 3, 2023 10:59
- Development
- Continents and cities
- Administration
- Network admin
* Add the backend with settings and a list with local items (core, plugins, themes)

* Save the checkbox value to enable local translations

* Add a message to hide the local translations if you have not enable them

* Add the originals and the translations strings for the core

* Split the translate_core method in smaller methods

* Add the 4 WordPress core subprojects and the main project.

* Add the functionality to translate locally a plugin

* Add the functionality to translate locally a theme

* Redirect to the selected plugin or theme, not to the main project

* Add the nonces in the URL and their checks

* Add some checks

* Download the .po and .mo files from translate.w.org if they don't exist locally

* Redirect to the locale in the plugins and themes

* Check if the file downloaded from DotOrg has fired an error

* Add the local "languages" folder inside the plugins and themes to look for .po files

* Initial import of community-translator

* Preload translations

* Make saving work

* Fix lint errors

* JS Lint fixes

* Fix eslint errors

* Update for new eslint settings

* Incorporate text domain namespacing more deeply

* Lint fixes

* Lint fix

* fix warning

* Fix wrong parameter sequence

* typo

* Fix original lookup

* Speedup initial tree walking

* Looku placeholders

* Show user translations

* Modify translation after saving

* Fix linting

* Prioritize found translations when the context is dubious

* Remove help icon for now

* Expose the text domain for translations that were not found

* Don't replace placeholders as if they were new translations

---------

Co-authored-by: Jesús Amieiro <[email protected]>
* Implement a REST API for saving translations

* Remove some outdated default settings
* Inline Translation: Make it work in the customizer

* lint
* Improve multi-placeholder translation replacement

* Fix case where the output text was already a translation

* lint

* Initialize array

* Add renamed core projects

* Update new project paths
* Improve multi-placeholder translation replacement

* Fix case where the output text was already a translation

* lint

* Unify project creation

* Continued unification

* Improve behavior with an empty Local GlotPress

* Fix insertion of JS placeholders

* Improve button text

* Update assets

* Fix rebase error

* Lint fixes

* Add a welcome page

* Lint fixes

* typo

* Rename WordPress project to just WordPress

* Make more strings translatable

* Allow some HTML in descriptions

* Fix lint

* Require local GlotPress to be active for inline translation

* Fix lint

* Remove actions column if there are no actions

* Replace modified strings back in again

* Fix another edge case with reinsering translations

* Fix another edge case
akirk and others added 13 commits August 3, 2023 10:59
* Copy placeholder into textarea on click

* Adapt code to work for other kinds of placeholders

* Extract placeholders and make them clickable

* Add css to placeholder links

* Fix linting errors

* Refactor code to remove duplicate insertions

* Check if placeholders have been entered

* Change background color if placeholder is missing

* Use standard color codes

* Add checkmark and strikethrough to differentiate between used and unused placeholders

* Change placeholder font color to black

* Add placeholder list beneath each textarea for plurals

* Select the  inline translation textarea

* Fix placeholders issue for plurals

* Highlight one placeholder one at a time when clicked for multiple occurrences of placeholders in the textarea

* Add margin to placeholder div

* Show list of placeholders for each plural on popover display

* Fix relaying warnings from the server-side

* Fix margin for firefox browser

* Remove unused variable

* Remove the debug dependency

* Add a space

---------

Co-authored-by: Alex Kirk <[email protected]>
* Move the jQuery popover file to the assets directory

* Ignore the new location of the jquery.webui-popover
@akirk akirk requested review from amieiro and trymebytes and removed request for amieiro August 4, 2023 08:54
Copy link
Contributor

@trymebytes trymebytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested on translate.wordpress.org and no issues.

Copy link
Member

@ocean90 ocean90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that this should not be merged into the current milestone 4.0. There should be one last stable version (4.0) which doesn't have all these "Local GlotPress" changes. Once that's done this can be probably merged as a focus of a 5.0 release.

Copy link
Member

@amieiro amieiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested and works for me! Nice job!

@amieiro amieiro enabled auto-merge (squash) August 18, 2023 11:41
@amieiro amieiro dismissed ocean90’s stale review August 18, 2023 11:42

We are following the 2 releases approach suggested by Dominik, so I am going to dismiss this request

@amieiro amieiro merged commit 3b3c81d into develop Aug 18, 2023
@amieiro amieiro deleted the local branch August 18, 2023 11:43
ocean90 added a commit that referenced this pull request Aug 18, 2023
ocean90 added a commit that referenced this pull request Aug 18, 2023
@ocean90 ocean90 restored the local branch August 18, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants