Skip to content

Fix including the minified assets in the WP.org deploy #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akirk merged 8 commits into from
Jul 13, 2023
Merged

Fix including the minified assets in the WP.org deploy #1655

akirk merged 8 commits into from
Jul 13, 2023

Conversation

@akirk
Copy link
Member

@akirk akirk commented Jul 13, 2023 •
edited
Loading

Problem

The approach in #1654 doesn't include the built minified assets even though the example readme in https://github.com/10up/action-wordpress-plugin-deploy suggests otherwise.

It turns out that the action uses git archive if you don't have a .distignore. If we build the files into the git monitored directory, then those newly built files are ignored by git archive since it creates the archive from its index files.

Relates to #1587.

Solution

git commit the newly built files.

Tasks

@akirk akirk requested a review from pedro-mendonca July 13, 2023 09:12
@pedro-mendonca
Copy link
Member

pedro-mendonca commented Jul 13, 2023

I would like to understand why it's not working as expected according the https://github.com/10up/action-wordpress-plugin-deploy docs.
Still, the build directory works the same, so I think it's also fine.

@akirk
Copy link
Member Author

akirk commented Jul 13, 2023

Yes, the build works but then the built files are not included in SVN:

Sending        trunk/CHANGELOG.md
Sending        trunk/assets/css/style.css
Sending        trunk/assets/js/common.js
Sending        trunk/assets/js/editor.js
Sending        trunk/assets/js/glossary.js
Sending        trunk/assets/js/mass-create-sets-page.js
Sending        trunk/***.php

@akirk akirk changed the title Use a build directory to include the minified assets in the WP.org deploy Fix including the minified assets in the WP.org deploy Jul 13, 2023
@akirk akirk mentioned this pull request Jul 13, 2023
Merged
4 tasks
@akirk akirk requested a review from trymebytes July 13, 2023 10:30
@pedro-mendonca
Copy link
Member

pedro-mendonca commented Jul 13, 2023

Will adding the .distignore file solve it?

@akirk
Copy link
Member Author

akirk commented Jul 13, 2023

It would but why not just re-use the .gitattributes file, fix the bug upstream and use our bugfix in the interim?

@pedro-mendonca
Copy link
Member

pedro-mendonca commented Jul 13, 2023

Great that you've identified the bug upstream! :)
Whatever temporary bugfix on GlotPress side is fine, to be removed after the upstream bug is fixed.

@akirk akirk merged commit fbff404 into develop Jul 13, 2023
@akirk akirk deleted the wporg-build-dir branch July 13, 2023 18:10
@pedro-mendonca pedro-mendonca mentioned this pull request Jul 14, 2023
Closed
@amieiro amieiro mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trymebytes trymebytes trymebytes approved these changes

@pedro-mendonca pedro-mendonca Awaiting requested review from pedro-mendonca

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@akirk @pedro-mendonca @trymebytes