Improve placeholders match and visibility #1620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocean90
previously requested changes
Jun 8, 2023
ocean90
reviewed
Jun 8, 2023
Member
Author
…ls_with_ampersand_in_glossary
…at %\d+[bcdefglosuxEFGX] %1s - 1 minimum length %10s - 10 minimum length
pedro-mendonca
force-pushed
the
glossary-placeholders
branch
from
39ef69f to
93ffb21
Compare
…dability" Reverting because there is a bug in the code that gives a false positive match that should be handled in a different PR
amieiro
reviewed
Jan 24, 2024
amieiro
approved these changes
Jan 24, 2024
amieiro
dismissed
ocean90’s stale review
The strings were added to the DataProvider, so the requested changes were made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
%l,%1$l,%1$10l, etc ) (a5a059f)%1s,%2d,%10l, etc ) (0bb1c10)invisible-spaces(8ab786f)Why?
Improve the placeholders visibility as described in the issue #1619
Fix glossary matching items when preceded by known placeholders. Fixes #1570
Screenshots or screencast
The placeholders are now highlighted and the glossary items are matched when have placeholders before, after or both.