Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve translation strings consistency and comments to translators #1600

Merged
merged 5 commits into from
Apr 19, 2023

Conversation

pedro-mendonca
Copy link
Member

What?

Fix/improve the below issues with translation strings.

  • Merge Error with requesting changes in %s translation. and Error requesting changes in %s translation., using the first one for consistency with other similar strings: Error with approving %s translation. and Error with rejecting %s translation.
  • Fix some comments to translators where single %d is used instead of numbered placeholders.
  • Desambiguate the singular/plural placeholder where multiple placeholders are used, but only one is used for _n() singular/plural

This was based on this chat with @tobifjellner on Slack.

@pedro-mendonca pedro-mendonca requested a review from amieiro April 3, 2023 15:53
@amieiro amieiro merged commit e3bfeb3 into GlotPress:develop Apr 19, 2023
@pedro-mendonca pedro-mendonca deleted the i18n-wording branch April 19, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants