Check JSON for double array to fix fatal error #1569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trymebytes
force-pushed
the
fix-import-json-error
branch
from
65eccba to
eabbe94
Compare
trymebytes
force-pushed
the
fix-import-json-error
branch
from
4b40642 to
fdd03ac
Compare
Member
|
What's the source of the JSON file? |
akirk
requested changes
Feb 22, 2023
Member
|
@ocean90 we don't know but we have been able to reproduce the fatal error with a JSON file like this: |
ocean90
reviewed
Feb 23, 2023
trymebytes
requested review from
akirk and
ocean90
and removed request for
akirk and
ocean90
akirk
approved these changes
Feb 28, 2023
Member
akirk
left a comment
akirk
left a comment
There was a problem hiding this comment.
Works for me as expected. No fatal error anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the fatal error thrown below;
Why?
It throws a fatal error.
How?
The error is caused when a JSON file with a double array e.g
{"%s unread item":[["a ungelesen","b ungelesen"]]}is imported into a projectTesting Instructions
Screenshots or screencast