Add an action gp_after_project_form_fields to enable additional fields to be added #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirk
requested changes
Nov 30, 2022
There was a problem hiding this comment.
In our PR review in the glotpress chat we agreed that this can move forward, we'd just like the $project to be added as a parameter. Thank you!
akirk
reviewed
Dec 14, 2022
akirk
reviewed
Dec 14, 2022
akirk
previously approved these changes
Dec 14, 2022
akirk
reviewed
Dec 14, 2022
akirk
reviewed
Dec 14, 2022
amieiro
approved these changes
Dec 14, 2022
akirk
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR introduces a new action
gp_after_project_form_fieldswith developers can use to add additional form fields to GlotPress projects.Why?
Currently, plugins extending GlotPress need to override the whole template file in order to add additional form fields. This new action would allow them to easily place them after the default fields.
How?
This PR closes #969
When the project form is submitted, the additional form fields can be saved as described in the issue.