Add plural and plural forms labels to row previews and format the row editor accordingly #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with the above spacing between labels and original singular/plural
|
The commit 22e2856 moves the Plural forms labels above the Original texts. The commit ac9d084 removes the margin from the Plural form label and the Translation text. Please check the comment #1505 (comment) on the issue. |
pedro-mendonca
changed the title
|
Removed minified asset from the PR accordingly this chat with @amieiro about including minified assets. The minified diffs is unreadable, and merging it creates conflicts with other pending PRs that are very difficult to keep up with. It's better to build all the assets on the repo, after all the merge sessions are complete. |
|
We agreed on our triage session that this can be merged after a code review. The functionality is fine. |
amieiro
previously approved these changes
Apr 18, 2023
|
The PR is now again free of conflicts. |
amieiro
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add plurals to original in the translation row preview, and add plural forms labels, accordingly to translate.wp.org
Why?
When filtering the Untranslated strings, there is no visual information about plural strings, either on original or translation column.
Example:
If the translation is added, only the translation shows the plural forms.
How?
This PR adds the same logic to the template as the template on wp.org, implementing this:
Result for Singular/Plural (e.g.: Portuguese):
Result for other plural form (e.g.: Russian):
Testing Instructions
Fixes #1505