Set as old the previous translations with changes requested #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a unit test for this? |
trymebytes
approved these changes
Nov 24, 2022
akirk
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When a translator suggests different translations for the same original and the validator request changes for these translations, the old translations are not marked as "old", so we have the history in the main table.
Fixes #1496.
Why?
This PR solves the problem explained in #1496.
How?
This PR sets the previous translations with "changesrequested" status as old:
Testing Instructions
You can follow the steps available in #1496 to test this PR.
Screenshots or screencast
See #1496.