Skip to content

Conversation

@dd32
Copy link
Contributor

@dd32 dd32 commented Sep 26, 2022

What?

We're using the GP_Locales for various purposes on WordPress.org, and in one of them I noticed some irregularities in some country_codes listed.

  • de_AT lists the country code as de, instead of at
  • fa_AF doesn't list the country code, but includes the country specifier in the locale, so might as well define country_code.

Notably, I've ignored the following locales, which specify a country in the WP locale:

  • fa_IR (Persian) - appears to just be the root Persian language, fa_AF above is a variant of Persian?
  • ms_MY (Malay) - Is the only Malay included, so no need to specify that it's the Malaysian Malay.

Why?

Although not the intended use-cases, this had resulted in:

  • de_DE and de_AT being localised to de rather than de and at. de_CH is correctly set to ch.
  • fa_AF being listed as just fa as it doesn't specify the country code.

How?

Testing Instructions

Screenshots or screencast

@dd32 dd32 added [Type] Bug An existing feature is broken. [Type] Locales labels Sep 26, 2022
@amieiro amieiro enabled auto-merge (squash) October 5, 2022 09:23
@amieiro amieiro merged commit a4436a6 into GlotPress:develop Oct 5, 2022
@ocean90 ocean90 added this to the 4.0 milestone Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug An existing feature is broken. [Type] Locales

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants