Bulk status change: Fix bulk rejection #1486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd32
changed the title
Contributor
Author
|
It appears this is probably the underlying cause of https://meta.trac.wordpress.org/ticket/6488 as it'll have set the Database rows to have an empty translation status field. |
amieiro
approved these changes
Sep 19, 2022
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As a follow up to #1451, it looks like the
actionPOST variable was looked at incorrectly, causing a PHP Notice:Based on https://github.com/amieiro/GlotPress-WP/blob/develop/gp-includes/routes/translation.php#L375-L381 it looks like the correct is
reject, which is confirmed from the POST data attached to the above notice containing 'reject'.I believe this is potentially causing bulk rejections to fail, based on re-attempts after failure.
Additionally,
$new_statusshould probably be pre-set torejectedbefore theswitch.Why?
How?
Testing Instructions
Screenshots or screencast