Add word count type to each Locale #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocean90
approved these changes
Sep 10, 2022
7 tasks
pedro-mendonca
added a commit
to pedro-mendonca/GlotPress
that referenced
this pull request
Sep 10, 2022
Property added in GlotPress#1482
ocean90
added a commit
that referenced
this pull request
Oct 10, 2022
* Add characters and words counts to editor * Fix coding standards * Rever some css to minimize changes * Update assets/js/editor.js Use 'input' instead of 'change keyup paste' Co-authored-by: Dominik Schilling <[email protected]> * Update gp-templates/helper-functions.php Use number_format_i18n() Co-authored-by: Dominik Schilling <[email protected]> * Update gp-templates/helper-functions.php Use number_format_i18n() Co-authored-by: Dominik Schilling <[email protected]> * Use core Wordcound package * Use only Wordcount package to count words and characters Supports the words type set in the installed language * Add translation ID to the textarea to fix unique IDs for multiple translations for the same original ID * Fix WPCS * Update counts for all textareas from an editor row * Simplify jQuery * Move counts HTML from PHP to JS to format all in one place. * Use the new GP_Locale word_count_type property Property added in #1482 * Render counts wrapper only if textarea is editable Co-authored-by: Dominik Schilling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds the
word_count_typeto each locale. The default is 'words'.Why?
The word count type can be used in the editor on submitting translations.
Related to #1478
Fixes #1481