Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the alphabet for each locale #1479

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Conversation

amieiro
Copy link
Member

@amieiro amieiro commented Sep 7, 2022

What?

This PR adds the alphabet for each locale. I set, by default, the Latin alphabet.

Why?

The alphabet can be used for a lot of decisions depending on the alphabet: counting letters and words, starting uppercase, finish symbols (points, ...), so it can be used as base for another improvements.

How?

This PR adds a new property ($alphabet), and have Latin as default value. Then adds the alphabet for each locale if its alphabet it is not the default.

@ocean90 ocean90 added the [Type] Enhancement A suggestion for improvement. label Sep 9, 2022
@ocean90 ocean90 added this to the 4.0 milestone Sep 9, 2022
Copy link
Member

@ocean90 ocean90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't verify all the locales but overall this looks good to me.

@amieiro amieiro merged commit fabbe2f into GlotPress:develop Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants