Merge the GlotDict hotkeys in GlotPress #1456
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e one Add this new hotkeys: - Ctrl-Shift-C - Cmd-Shift-B - Cmd-Shift-C Remove the Ctrl-Enter hotkey, because it will be used to Suggest or Save in another commiit.
…ning validation for the current visible editor.
…editor - Ctrl-Shift-D -> Ctrl-D - Cmd-Shift-D -> Cmd-D
- Ctrl-Shift-D - Cmd-Shift-D
- Ctrl-Left Arrow - Cmd-Left Arrow
- Ctrl-Right Arrow - Cmd-Right Arrow
- Alt-Left Arrow or Option-Left Arrow = Move to the previous page. - Alt-Right Arrow or Option-Right Arrow = Move to the next page.
…rst translation in the table Alt-1 or Option-1 = Show the editor for the first translation in the table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR improves the GlotPress hotkeys, as we discussed here.
Why?
In the last years, GlotDict has added some interesting hotkeys for translate.wordpress.org. This PR tries to bring the changes to GlotPress, so we can have the same new or updated hotkeys in GlotPress an at translate.w.org. Also, fixes some missing hotkeys for macOS.
How?
This PR updates the hook for the keydown event, available in the editor.js file. This update only affects the editor.
This PR adds a new file,
assets/js/hotkeys.jswith the global hotkeys, working in all GlotPress functionality, not only in the editor.Testing Instructions
?to show the popup with the help, or click on the new link in the footer.Escto close the help.Screenshots or screencast
This is the new link in the footer. When you click it, you will see the popover.
This is the popover with a list of the hotkeys. This popover can be used as documentation of the hotkeys.