Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-lock.json #1452

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Update package-lock.json #1452

merged 4 commits into from
Jul 13, 2022

Conversation

pedro-mendonca
Copy link
Member

Update package-lock.json to fix npm ci error

amieiro added a commit to amieiro/GlotPress that referenced this pull request Jun 15, 2022
amieiro added a commit to amieiro/GlotPress that referenced this pull request Jun 15, 2022
@pedro-mendonca pedro-mendonca requested a review from ocean90 June 15, 2022 10:51
amieiro added a commit to amieiro/GlotPress that referenced this pull request Jun 15, 2022
amieiro added a commit to amieiro/GlotPress that referenced this pull request Jun 20, 2022
@ocean90 ocean90 merged commit 194c7a7 into GlotPress:develop Jul 13, 2022
amieiro added a commit that referenced this pull request Sep 15, 2022
* PoC: Add the changes requested status

* Add a new hided button for the new status

* Add a new listener for the new status button

* Add the new status (changes_requested) in the bulk post and bulk approve

* Update a failing test

* Update the package-lock.json with "npm update"

* Update the package-lock.json with "npm update"

* Update the package-lock.json from #1452

* Add the minimized JavaScript

* Add some checks to view the new status only with the WPORG_TRANSLATE_BLOGID constant available

To view the new status in the frontend, you need to add the WPORG_TRANSLATE_BLOGID
constant in the wp-config.php file with the value of the get_current_blog_id() function. E.g.:

   define( 'WPORG_TRANSLATE_BLOGID', 1 );

* Update the check to see if the gp-translation-helpers plugin is installed

Check if the 'gp_translation_helper_installed' filter returns true -> plugin installed.

* Update the filter name from gp_translation_helper_installed to gp_enable_changes_requested_status

* Some updates to show the changes_requested strings as rejected if the gp_enable_changes_requested_status is not enabled

* Set the changes_requested as untranslated if the gp_enable_changes_requested_status is not enabled

* Update the margin for the action buttons

* Update the hook for the changes_requested buttons

* Update texts: changes_requested to changesrequested and request_changes to requestchanges

* Resolve a bug in the filter form

* Update the changesrequested showed value, with the uppercase

* Bugfix. Update the value for the changesrequested value if this status is not enabled

* Rearrange some conditions in an if statement

* Add some comments in an if and remove some parenthesis

* Add some comments in an if and remove some parenthesis

* Add a stub for set_status_changesrequested, avoiding breaking the plugin when the gp-translation-helpers plugin is not installed.

Props @akirk #1451 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants