Add a new status: changes requested #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BLOGID constant available To view the new status in the frontend, you need to add the WPORG_TRANSLATE_BLOGID constant in the wp-config.php file with the value of the get_current_blog_id() function. E.g.: define( 'WPORG_TRANSLATE_BLOGID', 1 );
…lled Check if the 'gp_translation_helper_installed' filter returns true -> plugin installed.
akirk
reviewed
Aug 4, 2022
…ble_changes_requested_status
… gp_enable_changes_requested_status is not enabled
…quested_status is not enabled
akirk
reviewed
Aug 5, 2022
…es to requestchanges
akirk
requested changes
Aug 31, 2022
…gin when the gp-translation-helpers plugin is not installed. Props @akirk GlotPress#1451 (review)
akirk
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
I've tested that the PR doesn't change the behavior of GlotPress unless I use it in combination with GlotPress/gp-translation-helpers#65, which is exactly what we want.
samuelsidler
added a commit
to samuelsidler/GlotPress
that referenced
this pull request
Aug 18, 2023
Buttons margins appear to have broken after GlotPress#1451 and are now misaligned. This adjusts them back to the pre-1451 state. Fixes GlotPress#1676.
Merged
amieiro
pushed a commit
that referenced
this pull request
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR, with another one in the gp-translation-helpers plugin, adds a new status: changes requested.
Solution
GlotPress stores a new status (changes_requested) when:
Testing instructions
To test this PR, you have to use the related branch from gp-translation-helpers plugin and you have to reject some strings as validator (simple or bulk rejection), adding some feedback.
Screenshots or screencast
The new status in the main table:
The new status in a string:
Rejecting a string:
When a validator adds feedback (reason and/or comment), the "Reject" button becomes "Request changes", so the validator sets the string in this new status. A notification is sent to the translator.
Making a bulk reject:
When a validator adds feedback (reason and/or comment), the "Reject" button becomes "Request changes", so the validator sets the string in this new status. A notification is sent to the translator.
The new status in the filters: