-
Notifications
You must be signed in to change notification settings - Fork 134
Check the missing uppercase in the beginning of the translations #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ginning of the translations
…rcase Use regex to detect if the original and the translation start with uppercase or lowercase. Sends notifications when a comment changes its status to "approve" Sends notifications when a comment changes its status to "approve"
30ca955 to
0c7136c
Compare
ocean90
reviewed
Jul 18, 2022
Member
|
Can we split the addition of the |
ocean90
reviewed
Sep 20, 2022
Member
ocean90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All warnings can be discarded so I think we should use the existing wording for the new warnings too.
Co-authored-by: Dominik Schilling <[email protected]>
Co-authored-by: Dominik Schilling <[email protected]>
ocean90
reviewed
Oct 10, 2022
ocean90
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR checks:
When some of these situations are found, the checker adds a warning.
See #1441.
Why?
In a lot of translations, the translators forget to start the translation with uppercase when the original string starts with uppercase or starts the translation with lowercase when the original starts with lowercase.
How?
This PR:
locales/locales.phpfile, but it could be useful in the future, and it is a work that takes a few hours.Testing Instructions
This PR adds some tests for the new warning method. To execute it, run:
composer testto run all tests.vendor/bin/phpunit --filter test_missing_uppercase_beginningto run only the new tests.Screenshots or screencast