-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sort by string length #1449
Conversation
I was unsure about the wording as well. I considered "Original string length" or "Source string length" and "String length", but "Original length" is also fine. |
String length maybe fine, with "(original)", for consistency. "String length (original)" Still, Original length might be simpler. |
If no-one comments on this one, could we probably merge it with "Original length". It's fine for me, and if anyone objects, we can change it later at any time. IMHO the wording should not stop us from integration here. Regarding the process, can you alter the code upon merging (including the indention) or shall I change it and add a new PR? |
To change the wording you just need to add a new commit to the same branch and it will be added to this PR. For merging, please wait for @ocean90 to review. |
I did now change the title and indention. What about then next steps. This small change seems to take forever to get reviewed. If there are further complains, please let me know (or at least any signs why this takes ages). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
During the translation process, the string length can be very important. Sometimes it's easier to translate rather long strings as the reference is less important and the string stands for itself. In other times, short strings are easier, at least to progress quickly.
Last but not least, sorting by string length allows to locate too short or malformed translations like " and " more quickly.
This PR just adds the sort by string property.