Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sort by string length #1449

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Added sort by string length #1449

merged 2 commits into from
Jul 18, 2022

Conversation

CWBudde
Copy link
Contributor

@CWBudde CWBudde commented Jun 9, 2022

During the translation process, the string length can be very important. Sometimes it's easier to translate rather long strings as the reference is less important and the string stands for itself. In other times, short strings are easier, at least to progress quickly.

Last but not least, sorting by string length allows to locate too short or malformed translations like " and " more quickly.

This PR just adds the sort by string property.

@pedro-mendonca
Copy link
Member

I like this sorting and it works perfectly.

Maybe rename it to "Original length" to make it clear about which string is being measured.
imagem

@CWBudde
Copy link
Contributor Author

CWBudde commented Jun 15, 2022

Maybe rename it to "Original length" to make it clear about which string is being measured.

I was unsure about the wording as well. I considered "Original string length" or "Source string length" and "String length", but "Original length" is also fine.

@pedro-mendonca
Copy link
Member

String length maybe fine, with "(original)", for consistency.

"String length (original)"

Still, Original length might be simpler.

@CWBudde
Copy link
Contributor Author

CWBudde commented Jun 16, 2022

If no-one comments on this one, could we probably merge it with "Original length". It's fine for me, and if anyone objects, we can change it later at any time. IMHO the wording should not stop us from integration here.

Regarding the process, can you alter the code upon merging (including the indention) or shall I change it and add a new PR?

@pedro-mendonca
Copy link
Member

pedro-mendonca commented Jun 17, 2022

To change the wording you just need to add a new commit to the same branch and it will be added to this PR.
If you prefer I can fix it for you.

For merging, please wait for @ocean90 to review.

@CWBudde
Copy link
Contributor Author

CWBudde commented Jun 19, 2022

I did now change the title and indention. What about then next steps. This small change seems to take forever to get reviewed. If there are further complains, please let me know (or at least any signs why this takes ages).
[sorry for being so impatient]

Copy link
Member

@pedro-mendonca pedro-mendonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pedro-mendonca pedro-mendonca requested a review from ocean90 June 22, 2022 10:51
@ocean90 ocean90 added this to the 4.0 milestone Jul 18, 2022
@ocean90 ocean90 added the [Type] Enhancement A suggestion for improvement. label Jul 18, 2022
@ocean90 ocean90 merged commit fc7b239 into GlotPress:develop Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants