Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a template for the PR #1448

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Conversation

amieiro
Copy link
Member

@amieiro amieiro commented Jun 8, 2022

This PR adds a template for the PR, so the person who sends the PR has to explain a few details around the PR, and the maintainer will have more information to review it.

More info about template PR on GitHub can be found here.

@ocean90
Copy link
Member

ocean90 commented Jun 8, 2022

I think we should have a more simple template without any checkboxes. See WordPress/gutenberg#39229 and WordPress/gutenberg#40470 for some background.

@amieiro
Copy link
Member Author

amieiro commented Jun 8, 2022

Could be interesting to copy this template, adapting it to GlotPress?

@pedro-mendonca
Copy link
Member

What about an optional footer link for an existing related issue that gets fixed with the PR?

Example:
Fixes #[issue-number]

@amieiro
Copy link
Member Author

amieiro commented Jun 15, 2022

What about an optional footer link for an existing related issue that gets fixed with the PR?

Example: Fixes #[issue-number]

If we want a simple template, I think this could be added in the ## Why? section. The template adds HTML comments with this information, as you can see in the next screenshot.

image

@pedro-mendonca
Copy link
Member

Great, missed that :)

@ocean90 ocean90 added this to the 4.0 milestone Jul 18, 2022
@ocean90 ocean90 merged commit 292c25a into GlotPress:develop Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants