Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1423: Add "Last Modified" column to Glossary #1428

Merged
merged 11 commits into from
Sep 12, 2022
Merged

1423: Add "Last Modified" column to Glossary #1428

merged 11 commits into from
Sep 12, 2022

Conversation

pedro-mendonca
Copy link
Member

@pedro-mendonca pedro-mendonca commented May 4, 2022 •
edited
Loading

This PR already includes the data-sorter for tablesorter added on #1426

  • Add Last Modified column to Glossary
  • Add data-sorter to column to set as sorteable
  • Add timestamp data-text to row data to sort alphabetically
  • Format data and time both in row and editor
  • Fix timezone offset

Fixes #1423

@pedro-mendonca pedro-mendonca requested a review from ocean90 May 4, 2022 13:21
@pedro-mendonca pedro-mendonca force-pushed the glossary-last-modified branch from 5e88add to 9e140e5 Compare July 13, 2022 14:59
@pedro-mendonca
Copy link
Member Author

This PR still requires a build step for the .min.css, should I build and add for review?

ocean90
ocean90 requested changes Sep 10, 2022
View reviewed changes
Copy link
Member

@ocean90 ocean90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes related to date handling.

@ocean90 ocean90 added this to the 4.0 milestone Sep 10, 2022
@ocean90 ocean90 added the [Type] Enhancement A suggestion for improvement. label Sep 10, 2022
@pedro-mendonca
Copy link
Member Author

All suggestions applied, done.

ocean90
ocean90 requested changes Sep 12, 2022
View reviewed changes
pedro-mendonca and others added 11 commits September 12, 2022 08:37
@ocean90 ocean90 force-pushed the glossary-last-modified branch from ed015ca to a857e72 Compare September 12, 2022 06:37
@ocean90 ocean90 merged commit 3363095 into GlotPress:develop Sep 12, 2022
@pedro-mendonca pedro-mendonca deleted the glossary-last-modified branch September 12, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocean90 ocean90 ocean90 approved these changes

Assignees
No one assigned
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Add a column showing the date when an entry has been added to the glossary
2 participants
@pedro-mendonca @ocean90