Adds a warning for added or removed spaces at the beginning or at the end of the translation #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… end of the translation
ocean90
requested changes
May 9, 2022
Remove unnecesary parenthesis. Co-authored-by: Dominik Schilling <[email protected]>
Remove space. Co-authored-by: Dominik Schilling <[email protected]>
|
The execution time with regex takes half of the time vs mb_strlen. I have tested it with this code: <?php // execution-time.php file
$original = ' Lorem ipsum ';
$translation = ' Lorem ipsum dolor sit ';
$number_of_executions = 10000000;
$time_start = microtime(true);
for ($i=0; $i<$number_of_executions; $i++){
preg_match( '/^( *)/D', $original, $m );
$original_start_spaces = strlen( $m[0] );
preg_match( '/^( *)/D', $translation, $m );
$translation_start_spaces = strlen( $m[0] );
preg_match( '/( *)$/D', $original, $m );
$original_end_spaces = strlen( $m[0] );
preg_match( '/( *)$/D', $translation, $m );
$translation_end_spaces = strlen( $m[0] );
}
$time_end = microtime(true);
echo 'Total execution time with regex: '.($time_end - $time_start).' s' . PHP_EOL;
for ($i=0; $i<$number_of_executions; $i++){
$original_start_spaces = mb_strlen( $original ) - mb_strlen( ltrim( $original, ' ' ) );
$original_end_spaces = mb_strlen( $original ) - mb_strlen( rtrim( $original, ' ' ) );
$translation_start_spaces = mb_strlen( $translation ) - mb_strlen( ltrim( $translation, ' ' ) );
$translation_end_spaces = mb_strlen( $translation ) - mb_strlen( rtrim( $translation, ' ' ) );
}
$time_end = microtime(true);
echo 'Total execution time with mb_strlen: '.($time_end - $time_start).' s'. PHP_EOL;Executing this code: $ php execution-time.php
Total execution time with regex: 3.5283000469208 s
Total execution time with mb_strlen: 7.8940501213074 s |
ocean90
approved these changes
Jun 7, 2022
This was referenced Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very usual that some strings to translate have empty spaces at their beginning or at the end.
The translators don't see if their translations have these empty spaces.
This PR adds some checks to warn the translators about these missing or unexpected spaces in their translations.