-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1376: Add CSS to current navigation menu item #1379
Conversation
93682e1
to
9b76231
Compare
9b76231
to
d795497
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocean90 it has too low contrast, hardly noted. The GlotPress title is wrapped in a |
Below are a few possible navbar solutions. These examples have the Projects as the
Please give feedback. |
In my opinion, the third option is the best: it is subtle, but it has more contrast than if you use gray or white. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the primary color as an underline for the current item sounds good too. But there's no need to use different colors for the left and right menu, they can use the same colors to keep it simple.
@ocean90 As I've mentioned above, the left and right colors show different status, on the left is a primary color to show the current status, and on the right I've placed a primary-color-200 to differentiate on hover on the current item. |
Thanks for fixing the loose ends :) |
This allows to clearly identify the active navigation menu item.
Change homeh1
tonav#home-navigation
for better:hover
consistency.current
underline color tobackground-color
--gp-color-primary
:hover
underline color tobackground-color
--gp-color-primary-200
(the color immediately above primary in the lighter spectrum).gp-bar
left and right padding to keep the navbar and content alignedUpdate:
h1
link as reviewedScreenshot
Projects
.current
and Locales:hover
Fixes #1376