Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify styling for tables #1338

Merged
merged 6 commits into from
Mar 22, 2022
Merged

Unify styling for tables #1338

merged 6 commits into from
Mar 22, 2022

Conversation

ocean90
Copy link
Member

@ocean90 ocean90 commented Mar 20, 2022 •
edited
Loading

Fixes #1337.

  • Introduce gp-table CSS class to DRY up code.
  • Use consistent colors for background and borders.
  • Add custom properties for translation status colors.
  • Use flex layout for table actions (bulk actions and paging).
  • Move form for creating a new glossary entry out of the table.
  • Update values for border color custom properties.
  • Remove TableSorter stylesheet.
  • Move breadcrumb nav to top.
  • Update styling for pagination.
  • Use consistent column classes and fix column width changes if no translations exist for the current filter.

After screenshots:

Bildschirmfoto 2022-03-20 um 14 13 54

Bildschirmfoto 2022-03-20 um 14 14 36

Bildschirmfoto 2022-03-20 um 14 14 16

Bildschirmfoto 2022-03-20 um 14 15 47

Bildschirmfoto 2022-03-20 um 14 16 30

Bildschirmfoto 2022-03-20 um 14 23 19

ocean90 added 2 commits March 19, 2022 21:10
@ocean90
Simplify and unify styling for tables
0e8d015 
* Use consistent colors for background and borders.
* Use flex layout for table actions (bulk actions and paging).
* Move form for creating a new glossary entry out of the table.
* Update values for border color custom properties
@ocean90
Remove extra stylehheet for tablesorter, integrate and simplify style…
9cbf5d0 
…s into main stylesheet
@ocean90 ocean90 added this to the 3.0 milestone Mar 20, 2022
@ocean90 ocean90 merged commit b15b989 into develop Mar 22, 2022
@ocean90 ocean90 deleted the try/unify-table-styles branch March 22, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Simplify and unify styling for tables
1 participant
@ocean90