Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locales: Update native name for Chinese (Hong Kong) #1309

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

ckykenken
Copy link
Contributor

Amended locale name for locale zh_HK

@ocean90
Copy link
Member

ocean90 commented Jan 24, 2022

Could you please provide some more info on the change? What is wrong with the current name and is there someone else who can confirm that this a better name? All the Chinese locales should at least follow the same format for the name.

@ckykenken
Copy link
Contributor Author

Chinese locales such as zh_TW and zh_CN are 繁體中文 and 简体中文 respectively. The locale zh_HK is not initiated by me, and there is an extra word and an extra tab inside the locale name when I look through the source code, the former of which looks awkward when put together with other Chinese locales and when it is showing up in some sites. The locale founder did not pay attention to the naming when initiating this locale.
For example, it exists a phrase for zh-TW 台灣正體中文版, which is Taiwan Traditional Chinese version when translated into English, but for zh-HK it turns out to be 香港中文版版, which looks awkward.
Hence I would like to have it be consistent.
image

@ocean90 ocean90 changed the title Update locales.php Locales: Update native name for Chinese (Hong Kong) Mar 13, 2022
@ocean90 ocean90 added this to the 3.0 milestone Mar 14, 2022
@ocean90 ocean90 enabled auto-merge (squash) March 14, 2022 07:52
@ocean90 ocean90 merged commit adada40 into GlotPress:develop Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants