Adding Catalan Valencian variant, #1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variant was already added on translations.wp.org (see https://make.wordpress.org/polyglots/2018/02/27/locale-cat-country-code-es/#comment-278706) It also exists on many other open-source projects: - Gnome https://l10n.gnome.org/teams/ca/ - Moodle https://download.moodle.org/langpack/3.4/ - Ubuntu https://translations.launchpad.net/ubuntu/focal/+lang/ca@valencia
ocean90
requested changes
Dec 13, 2021
Member
ocean90
left a comment
ocean90
left a comment
There was a problem hiding this comment.
Thanks for the PR, one minor change for the WP locale.
I was actually searching for the locale in the locales.php on w.org but it seems like it got accidentally removed in https://meta.trac.wordpress.org/changeset/9839.
Co-authored-by: Dominik Schilling <[email protected]>
Contributor
Author
|
So I guess it's a good Idea to have it here then ... :) That said, I only added it to |
xavivars
commented
Dec 13, 2021
Contributor
Author
|
@ocean90 , is there any change still required? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variant was already added on translations.wp.org (see https://make.wordpress.org/polyglots/2018/02/27/locale-cat-country-code-es/#comment-278706)
It also exists on many other open-source projects: