Skip to content

Add short-circuit hook in GP_Original::closest_original. #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ocean90 merged 3 commits into from
Jan 24, 2021
Merged

Add short-circuit hook in GP_Original::closest_original. #1207

ocean90 merged 3 commits into from
Jan 24, 2021

Conversation

@gedex
Copy link
Contributor

@gedex gedex commented Nov 24, 2020

Fixes #1204.

rcstr
rcstr previously approved these changes Nov 24, 2020
View reviewed changes
ocean90
ocean90 requested changes Nov 25, 2020
View reviewed changes
Copy link
Member

@ocean90 ocean90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! Let's clarify the supported types and update the @SInCE tag.

@ocean90 ocean90 added the [Type] Enhancement A suggestion for improvement. label Nov 25, 2020
@ocean90 ocean90 added this to the 3.0 milestone Nov 25, 2020
@gedex gedex requested a review from ocean90 December 2, 2020 13:12
@gedex
Copy link
Contributor Author

gedex commented Dec 2, 2020

Thanks for the feedback, @ocean90.

@ocean90 ocean90 merged commit 32414cd into GlotPress:develop Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocean90 ocean90 Awaiting requested review from ocean90

1 more reviewer

@rcstr rcstr rcstr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

Add short-circuit hook in GP_Original::closest_original

3 participants

@gedex @rcstr @ocean90